Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of EffectiveLifeYears int?->decimal? #409

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix type of EffectiveLifeYears int?->decimal? #409

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dd35d5
Fix type of EffectiveLifeYears int?->decimal?
Feb 7, 2022
9abe610
DOn't throw exception if fault with Json - just return null
Feb 15, 2022
dcdadbb
Revert "DOn't throw exception if fault with Json - just return null"
Feb 15, 2022
2fdb894
Revert "Revert "DOn't throw exception if fault with Json - just retur…
Feb 15, 2022
6669fbb
Merge branch 'master' into master
ionican Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Xero.NetStandard.OAuth2/Client/ApiClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ internal object Deserialize(IRestResponse response, Type type)
}
catch (Exception e)
{
throw new ApiException(500, e.Message);
//throw new ApiException(500, e.Message);
return null;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stet - not needed for this commit.

}
}

Expand Down
2 changes: 1 addition & 1 deletion Xero.NetStandard.OAuth2/Model/Asset/BookDepreciationSetting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public enum DepreciationCalculationMethodEnum
/// </summary>
/// <value>Effective life of the asset in years (e.g. 5)</value>
[DataMember(Name="effectiveLifeYears", EmitDefaultValue=false)]
public int? EffectiveLifeYears { get; set; }
public decimal? EffectiveLifeYears { get; set; }

/// <summary>
/// Unique Xero identifier for the depreciable object
Expand Down
2 changes: 1 addition & 1 deletion Xero.NetStandard.OAuth2/Xero.NetStandard.OAuth2.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<PackageReference Include="JsonSubTypes" Version="1.5.2" />
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="RestSharp" Version="106.11.4" />
<PackageReference Include="System.ComponentModel.Annotations" Version="4.5.0" />
<PackageReference Include="System.ComponentModel.Annotations" Version="6.0.0-preview.4.21253.7" />
</ItemGroup>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stet - not needed for this commit.


Expand Down