Release Python GIL during slow load I/O #8066
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andrew-bolin - is not a collaborator |
|
Can one of the admins verify this patch? |
|
andrew-bolin - is not a collaborator |
schelleg
approved these changes
May 31, 2024
There was a problem hiding this comment.
@skalade rebuilt pyxrt.so bindings and verified that AMDResearch/Riallto tests still pass with this global lock change.
|
\build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When using multiple FPGAs in multiple threads, loading XCLBINs cannot be performed concurrently as pyxrt holds the Python Global Interpreter Lock for the duration of the loading process.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
See AMD WTS support case 00410749
How problem was solved, alternative solutions (if any) and why they were rejected
GIL released during slow load operation. This fix was suggested by AMD support in November 2023, but was seemingly never submitted to the code base.
Risks (if any) associated the changes in the commit
Believed to be safe
What has been tested and how, request additional testing if necessary
AMD support said they have tested it.
A Python snippet to demonstrate the original issue (and prove the fix) is available - https://gitlab.com/ska-telescope/low-cbf/ska-low-cbf-fpga/-/snippets/3613095
Documentation impact (if any)
None