Fixed ERT firmware packaging issue #8190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fquinner - is not a collaborator |
|
Can one of the admins verify this patch? |
When proving the user's own sched*.bin binaries, the ERTFW_FILES variable contains the required ERT firmware files but it is only used in one target firmware location in the target install directory structure. This fix ensure it is also added to the directory expected by the xrt base packages. Signed-off-by: Frank Quinn <[email protected]>
|
fquinner - is not a collaborator |
|
\build |
|
fquinner - is not a collaborator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proving the user's own
sched*.binbinaries, theERTFW_FILESvariable contains the required ERT firmware files but it is only used in one target firmware location in the target install directory structure. This fix ensure it is also added to the directory expected by the xrt base packages.Problem solved by the commit
RPM package created does not contain the sched bin files in /opt/xilinx/xrt/share/fw. This causes the xrt base RPM to fail to build the required XSA shells so they in turn silently fail.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Discovered while trying to set up a Xilinx card with XRT for the first time.