CID-300588, 307566, 307559 #8256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/core/pcie/driver/linux/xocl/userpf
|
Can one of the admins verify this patch? |
|
Signed-off-by: Hayden Laccabue [email protected] |
saifuddin-xilinx
approved these changes
Jun 28, 2024
|
Hi @hlaccabu . Changes look good. Can we change the title of the PR to include the CID numbers you have fixed? |
hlaccabu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a few Coverity issues found in a couple files in /src/runtime_src/core/pcie/driver/linux/xocl/userpf
Problem solved by the commit
A few issues found by the Coverity scan that could cause problems.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Copy into fixed size buffer, uninitialized scalar variable, and logically dead code in xocl_hwctx.c, xocl_ioctl.c, and xocl_sysfs.c, respectively.
How problem was solved, alternative solutions (if any) and why they were rejected
Use strlcpy() instead of strcpy(), initialized uninit variable to 0 (as is consistent with rest of code), and removed conditional that was logically dead.