-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up the aiebu submodule version to resolve link with aie-rt failu… #8353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
696efff
to
57f42ca
Compare
…re in Windows build Signed-off-by: Sonal Santan <[email protected]>
…ings Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
… Windows MCDM build Signed-off-by: Sonal Santan <[email protected]>
…rnings Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
ffe86bc
to
38e26e5
Compare
Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
Signed-off-by: Sonal Santan <[email protected]>
vipangul
pushed a commit
to vipangul/XRT
that referenced
this pull request
Sep 11, 2024
Xilinx#8353) * Bump up the aiebu submodule version to resolve link with aie-rt failure in Windows build Signed-off-by: Sonal Santan <[email protected]> * Update submodule, aiebu git hash which resolves windows compiler warnings Signed-off-by: Sonal Santan <[email protected]> * Resolve dead code warning in XDP plugin breaking Windows build Signed-off-by: Sonal Santan <[email protected]> * Disable an incorrect? unreachable warning in aie_hlt.cpp which breaks Windows MCDM build Signed-off-by: Sonal Santan <[email protected]> * Pull in the latest aiebu which resolves the last remaining Windows warnings Signed-off-by: Sonal Santan <[email protected]> * Bump up aiebu submodule to resolve warnings in its test code Signed-off-by: Sonal Santan <[email protected]> * More cleanups to make MSVC warning supression MSVC specific Signed-off-by: Sonal Santan <[email protected]> * Guard the #pragma warning with _WIN32 Signed-off-by: Sonal Santan <[email protected]> * Temporary fix to resolve aie-rt warnings causing build failure Signed-off-by: Sonal Santan <[email protected]> * Bump up the aiebu git hash to get additional build fixes Signed-off-by: Sonal Santan <[email protected]> * aiebu now uses cpack of the parent module Signed-off-by: Sonal Santan <[email protected]> * Pull in latest aiebu with install dir fixes Signed-off-by: Sonal Santan <[email protected]> --------- Signed-off-by: Sonal Santan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re in Windows build
Problem solved by the commit
Bump up the submodule aiebu hash to pick up latest changes to resolve aie-rt usage on Windows
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
git submodule has update. The actual fix went into aiebu submodule.
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Compile tested
Documentation impact (if any)
NA