Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (mx): automatic group_dim in layerwise quant #1012

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Aug 28, 2024

Depends on #1011

@Giuseppe5 Giuseppe5 changed the title Automatic groupdim Feat (mx): automatic group_dim in layerwise quant Aug 28, 2024
@Giuseppe5 Giuseppe5 requested a review from nickfraser August 29, 2024 11:38
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge after #1011.

@nickfraser
Copy link
Collaborator

FYI, this was rebased after #1011.

@nickfraser nickfraser self-requested a review September 4, 2024 10:18
@nickfraser nickfraser merged commit 0dfed16 into Xilinx:dev Sep 4, 2024
337 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants