Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (scaling): no tracked_parameter_list with individual quantizer #1112

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

Giuseppe5
Copy link
Collaborator

Reason for this PR

ViewParameterWrapper creates a shared weight within the quantizer. This doesn't play nice with accelerate.
We don't need this unless with shared quantizers which is not something we are currently using in combination with accelerate.

Changes Made in this PR

ViewWrapper can fill for this. However, we need to fallback to ViewParameterWrapper for some cases DecoupledWeightQuantization, so we have a special flag to enable that.

Testing Summary

NA

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 requested a review from nickfraser December 4, 2024 22:14
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser December 5, 2024 09:47
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser December 5, 2024 10:01
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser December 5, 2024 10:18
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser December 5, 2024 10:32
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Giuseppe5 Giuseppe5 merged commit 7caa716 into Xilinx:dev Dec 6, 2024
374 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants