Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (llm/equalize): remove call to _update_weights #1216

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Fix (llm/equalize): remove call to _update_weights #1216

merged 2 commits into from
Mar 10, 2025

Conversation

pablomlago
Copy link
Collaborator

Reason for this PR

Function _update_weights no longer exists.

Changes Made in this PR

Removed call to _update_weights.

Testing Summary

Added a perplexity test for rotation with expansion.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@pablomlago pablomlago requested a review from Giuseppe5 March 10, 2025 14:03
@pablomlago pablomlago changed the base branch from master to dev March 10, 2025 14:03
@pablomlago pablomlago changed the title Fix (llm/equalize): change call to removed function Fix (llm/equalize): remove call to _update_weights Mar 10, 2025
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 March 10, 2025 15:26
@Giuseppe5 Giuseppe5 merged commit 4b4c334 into Xilinx:dev Mar 10, 2025
387 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giuseppe5 Giuseppe5 Awaiting requested review from Giuseppe5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablomlago @Giuseppe5