Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Change review_requested trigger to issue_comment trigger for full test suite #895

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Improvement: Change review_requested trigger to issue_comment trigger for full test suite #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e4c4f0
created skeleton of new workflow
costigt-dev Mar 6, 2024
deb593e
simplified skeleton for testing
costigt-dev Mar 6, 2024
715a3bd
replaced review_requested action with issue_comment one so tests don'…
costigt-dev Mar 7, 2024
09c17e8
changed to single quotes
costigt-dev Mar 7, 2024
14a0559
replaced double quotes with single quotes
costigt-dev Mar 8, 2024
b8e12a7
remove issue_comment trigger from reduced test suite
costigt-dev Mar 8, 2024
bf64336
updated template so automatic generation of workflows works correctly
costigt-dev Mar 14, 2024
da9d6ad
moved torchvision versions
costigt-dev Mar 14, 2024
9765de8
added back ready_for_review
costigt-dev Mar 15, 2024
5558ee9
fixed formatting issue
costigt-dev Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/base.yml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: &{name}
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -16,7 +15,7 @@ jobs:
&{matrix}
&{exclude}

if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft && (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' && contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/develop_install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Test develop install
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -22,7 +21,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/end_to_end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Test End-to-end flows
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -25,7 +24,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/examples_pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Examples Pytest
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -27,7 +26,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/finn_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Test Brevitas-FINN integration
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -22,7 +21,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/gen_github_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@

PYTORCH_LIST_REDUCED = ["1.9.1", "1.13.0", "2.1.0"]

# used by noxfile.py
TORCHVISION_VERSION_DICT = {
'1.9.1': '0.10.1',
'1.10.1': '0.11.2',
'1.11.0': '0.12.0',
'1.12.1': '0.13.1',
'1.13.0': '0.14.0',
'2.0.1': '0.15.2',
'2.1.0': '0.16.0'}

PLATFORM_LIST_REDUCED = ['ubuntu-latest']

MATRIX_REDUCED = od([('python_version', list(PYTHON_VERSIONS_REDUCED)),
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/notebook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Test Notebook execution
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -25,7 +24,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/ort_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Test Brevitas-ORT integration
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -22,7 +21,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/pre_commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ on:
- opened
- reopened
- synchronize
- ready_for_review
- review_requested

jobs:
pre_commit:
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ name: Pytest
on:
push:
branches: [ master, dev ]
pull_request:
types:
- review_requested
issue_comment:
types: [created]

jobs:
build:
Expand All @@ -27,7 +26,7 @@ jobs:



if: ${{ !github.event.pull_request.draft }}
if: ${{ !github.event.pull_request.draft & (github.event_name != 'issue_comment' || (github.event.issue.pull_request != '' & contains(github.event.comment.body, '/run-tests')))}}
steps:

- name: Checkout repo
Expand Down
10 changes: 1 addition & 9 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,14 @@
from gen_github_actions import JIT_STATUSES
from gen_github_actions import PYTHON_VERSIONS
from gen_github_actions import PYTORCH_VERSIONS
from gen_github_actions import TORCHVISION_VERSION_DICT

IS_OSX = system() == 'Darwin'
PYTORCH_STABLE_WHEEL_SRC = 'https://download.pytorch.org/whl/torch_stable.html'
PYTORCH_IDS = tuple([f'pytorch_{i}' for i in PYTORCH_VERSIONS])
JIT_IDS = tuple([f'{i}'.lower() for i in JIT_STATUSES])
LSTM_EXPORT_MIN_PYTORCH = '1.10.1'

TORCHVISION_VERSION_DICT = {
'1.9.1': '0.10.1',
'1.10.1': '0.11.2',
'1.11.0': '0.12.0',
'1.12.1': '0.13.1',
'1.13.0': '0.14.0',
'2.0.1': '0.15.2',
'2.1.0': '0.16.0'}

PARSED_TORCHVISION_VERSION_DICT = {version.parse(k): v for k, v in TORCHVISION_VERSION_DICT.items()}


Expand Down
Loading