Coverify fixes in QDMA driver #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CID 211019 : remove dead code in qdma_intr.c | data_intr_direct()
CID 249237 : missing_lock: Accessing reg_info->trig_mode without holding lock
CID 249253 : missing_lock: Accessing descq->q_state without holding lock
CID 257805 : Pointer &xdev->conf.qsets_max points to an object whose
effective type is unsigned short (16 bits, unsigned) but is
dereferenced as a wider unsigned int (32 bits, unsigned). This may
lead to memory corruption.
CID 257809 : missing_lock: Accessing descq->cmpt_cidx_info.trig_mode without
holding lock qdma_descq.lock
CID 257810 : missing_lock: Accessing descq->conf.cmpl_trig_mode without holding
lock qdma_descq.lock.
CID 257811 : missing_lock: Accessing descq->conf.cmpl_trig_mode without holding
lock qdma_descq.lock
Signed-off-by: Rajkumar Rampelli <[email protected]>
|
All QDMA driver coverity fixes can be found at https://scan.coverity.com/projects/xilinx-xrt-5f9a8a18-9d52-4cb2-b2ac-2d8d1b59477f |
Signed-off-by: Rajkumar Rampelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CID 211019 : remove dead code in qdma_intr.c | data_intr_direct() CID 249237 : missing_lock: Accessing reg_info->trig_mode without holding lock CID 249253 : missing_lock: Accessing descq->q_state without holding lock CID 257805 : Pointer &xdev->conf.qsets_max points to an object whose
effective type is unsigned short (16 bits, unsigned) but is
dereferenced as a wider unsigned int (32 bits, unsigned). This may
lead to memory corruption.
CID 257809 : missing_lock: Accessing descq->cmpt_cidx_info.trig_mode without
holding lock qdma_descq.lock
CID 257810 : missing_lock: Accessing descq->conf.cmpl_trig_mode without holding
lock qdma_descq.lock.
CID 257811 : missing_lock: Accessing descq->conf.cmpl_trig_mode without holding
lock qdma_descq.lock
CID 216748: Uninitialized scalar variable