Add float support to Slice by specializing Width and Caster template #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preusser
force-pushed
the
slice-float
branch
from
0aef01a to
fbf055d
Compare
|
Thanks, @iksnagreb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for implementing floating-point support for generic element-wise binary operations in FINN, proposed here: Xilinx/finn#1040
This does not change the behavior of
Slicefor already supported types, it just adds template a specialization ofCasterfor float viareinterpret_castand proposes a new mechanism of setting the defaultSTRIDEavoidingT::widthwhich doe not exist for floats.