Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashed AIRBIN generation and runtime #128

Closed
wants to merge 10 commits into from

Conversation

jgmelber
Copy link
Collaborator

This PR adds initial runtime support for AIRBINs from mlir-aie #243. AIRBIN generation and use is demonstrated in test/301_airbin_gen_add_one.

Copy link
Collaborator

@fifield fifield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we're checking in .airbin files instead of generating them?

@@ -67,5 +69,5 @@ foreach(file ${INSTALLS})
endforeach()

# Install files
set(INSTALLS memory.cpp queue.cpp host.cpp utility.cpp pcie-ernic.cpp pcie-ernic-dev-mem-allocator.cpp network.cpp)
set(INSTALLS airbin.cpp memory.cpp queue.cpp host.cpp utility.cpp pcie-ernic.cpp pcie-ernic-dev-mem-allocator.cpp network.cpp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line for good in a subsequent PR.

runtime_lib/airhost/airbin.cpp Show resolved Hide resolved
runtime_lib/airhost/airbin.cpp Outdated Show resolved Hide resolved
runtime_lib/airhost/include/airbin.h Show resolved Hide resolved
runtime_lib/airhost/include/airbin.h Outdated Show resolved Hide resolved
test/279_dual_herd/test.cpp Outdated Show resolved Hide resolved
test/300_relocatable_airbin_config/Makefile Outdated Show resolved Hide resolved
test/300_relocatable_airbin_config/test.cpp Outdated Show resolved Hide resolved
test/301_airbin_gen_add_one/Makefile Show resolved Hide resolved
test/301_airbin_gen_add_one/test.cpp Outdated Show resolved Hide resolved
@jgmelber jgmelber requested a review from fifield December 22, 2022 19:20
runtime_lib/airhost/airbin.cpp Outdated Show resolved Hide resolved
runtime_lib/airhost/airbin.cpp Outdated Show resolved Hide resolved
runtime_lib/airhost/airbin.cpp Outdated Show resolved Hide resolved
runtime_lib/airhost/airbin.cpp Outdated Show resolved Hide resolved
runtime_lib/airhost/airbin.cpp Outdated Show resolved Hide resolved
@jgmelber jgmelber marked this pull request as ready for review January 3, 2023 16:46
@jgmelber
Copy link
Collaborator Author

Work continued by #259

@jgmelber jgmelber closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants