-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squashed AIRBIN generation and runtime #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we're checking in .airbin
files instead of generating them?
@@ -67,5 +69,5 @@ foreach(file ${INSTALLS}) | |||
endforeach() | |||
|
|||
# Install files | |||
set(INSTALLS memory.cpp queue.cpp host.cpp utility.cpp pcie-ernic.cpp pcie-ernic-dev-mem-allocator.cpp network.cpp) | |||
set(INSTALLS airbin.cpp memory.cpp queue.cpp host.cpp utility.cpp pcie-ernic.cpp pcie-ernic-dev-mem-allocator.cpp network.cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this line for good in a subsequent PR.
1b294fd
to
0f9764b
Compare
Work continued by #259 |
This PR adds initial runtime support for AIRBINs from mlir-aie #243. AIRBIN generation and use is demonstrated in test/301_airbin_gen_add_one.