Improve compile time (AIRRtToNpuPass) #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the cache implementation, which made the compilation go faster! Changes have been merged into #550 Maybe we can close this one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces total end-to-end compile time from 7 seconds to 0.5 seconds on one model. At some point I had a model which was spending 2+ minutes in this air pass, I am optimistic that this optimization reduces that too (I can't recall the matmul dimensions).
I am currently trying to build mlir-air outside of IREE to check locally that all the tests pass, but I'm also just throwing this to CI now to check.