Skip to content

AIRCopyToDma: Unblock dynamic shaped memrefs #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Draft

AIRCopyToDma: Unblock dynamic shaped memrefs #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions mlir/lib/Conversion/ConvertToAIRPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ matchAndRewriteCopyOp(memref::CopyOp op, RewriterBase &rewriter) {
(dst_type.getMemorySpaceAsInt() == (int)air::MemorySpace::L3))
return failure();

if (!(src_type.hasStaticShape() || dst_type.hasStaticShape()))
return failure();

SmallVector<Value, 4> src_offsets, dst_offsets;
SmallVector<Value, 4> src_strides, dst_strides;
SmallVector<Value, 4> src_sizes, dst_sizes;
Expand All @@ -73,7 +70,9 @@ matchAndRewriteCopyOp(memref::CopyOp op, RewriterBase &rewriter) {
auto &strides) {
auto subview_offsets = subview.getOffsets().begin();
auto static_offsets = subview.getStaticOffsets();
auto subview_sizes = subview.getSizes().begin();
auto static_sizes = subview.getStaticSizes();
auto subview_strides = subview.getStrides().begin();
auto static_strides = subview.getStaticStrides();
auto loc = subview.getLoc();

Expand All @@ -98,9 +97,15 @@ matchAndRewriteCopyOp(memref::CopyOp op, RewriterBase &rewriter) {
offsets.push_back(*subview_offsets++);
}
for (auto s : static_sizes)
sizes.push_back(rewriter.create<arith::ConstantIndexOp>(loc, s));
if (s >= 0)
sizes.push_back(rewriter.create<arith::ConstantIndexOp>(loc, s));
else
sizes.push_back(*subview_sizes++);
for (auto s : layout_strides)
strides.push_back(rewriter.create<arith::ConstantIndexOp>(loc, s));
if (s >= 0)
strides.push_back(rewriter.create<arith::ConstantIndexOp>(loc, s));
else
strides.push_back(*subview_strides++);
};

if (auto subview = src.getDefiningOp<memref::SubViewOp>()) {
Expand Down