Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, eth: announce based transaction propagation #891

Open
wants to merge 8 commits into
base: dev-upgrade
Choose a base branch
from

Conversation

JukLee0ira
Copy link

Proposed changes

fix issue #862

  • testing on testnet

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@@ -302,7 +322,7 @@ func (pm *ProtocolManager) Start(maxPeers int) {

// start sync handlers
go pm.syncer()
go pm.txsyncLoop()
go pm.txsyncLoop() //TODO:mv to txsyncLoop64?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, should rename txsyncLoop() to txsyncLoop64()

@@ -32,17 +32,18 @@ import (
const (
eth62 = 62
eth63 = 63
eth65 = 65
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR support eth65 fully ? Can we skip eth64 ?

@gzliudan
Copy link
Collaborator

gzliudan commented Mar 4, 2025

Notice: XDC nodes are using xdpos2/100 protocol. All nodes meet this conditions in your code: p.version >= eth65

@JukLee0ira JukLee0ira force-pushed the more_metrics branch 2 times, most recently from 0c481b6 to 7035150 Compare March 11, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants