DPF-01

XinFinOrg · May 21, 2024 · 2b35480 · 2b35480
1 parent 2baf69b
commit 2b35480
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/contracts/src/DaofinPlugin.sol b/packages/contracts/src/DaofinPlugin.sol
@@ -662,10 +662,10 @@ contract DaofinPlugin is BaseDaofinPlugin {
     }
 
     function editProposalMetadata(uint256 _proposalId, bytes calldata _metadata) external {
-        (bool open, , address proposer, , , ) = getProposal(_proposalId);
+        (bool open, bool executed, address proposer, , , ) = getProposal(_proposalId);
 
         // Proposal must be before election its attached election period.
-        if (!open) revert InValidTime();
+        if (open || executed) revert InValidTime();
 
         // Only proposer address is able to modify metadata.
         if (proposer != _msgSender()) revert InValidAddress();

diff --git a/packages/contracts/test/unit-testing/daofin/update-proposal-metadata.test.ts b/packages/contracts/test/unit-testing/daofin/update-proposal-metadata.test.ts
@@ -122,6 +122,8 @@ describe(PLUGIN_CONTRACT_NAME, function () {
       [
         BigNumber.from(now + 60 * 60 * 24 * 3),
         BigNumber.from(now + 60 * 60 * 24 * 5),
+        BigNumber.from(now + 60 * 60 * 24 * 10),
+        BigNumber.from(now + 60 * 60 * 24 * 12),
       ],
       [Bob.address],
       '1',
@@ -131,7 +133,7 @@ describe(PLUGIN_CONTRACT_NAME, function () {
     await daofinPlugin.joinHouse({value: parseEther('1')});
   });
   describe('Modify Proposal Metadata', async () => {
-    it('Modify proposal', async () => {
+    it('must not revert if it is before starting period', async () => {
       createPropsalParams = createProposalParams(
         '0x00',
         [],
@@ -153,12 +155,12 @@ describe(PLUGIN_CONTRACT_NAME, function () {
       );
       await proposalTx.wait();
 
-      await expect(daofinPlugin.editProposalMetadata(proposalId, '0x01')).to
+      await expect(daofinPlugin.editProposalMetadata(proposalId, '0x01')).to.not
         .reverted;
 
       await advanceTime(ethers, convertDaysToSeconds(4));
 
-      await expect(daofinPlugin.editProposalMetadata(proposalId, '0x01')).to.not
+      await expect(daofinPlugin.editProposalMetadata(proposalId, '0x01')).to
         .reverted;
 
       const proposal = await daofinPlugin._proposals(proposalId);