Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/libnvml): fix removal for process info v3 APIs on the upstream 535.98 driver #89

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

XuehaiPan
Copy link
Owner

@XuehaiPan XuehaiPan commented Aug 16, 2023

Issue Type

  • Bug fix

Description

Add an extra handler to check the removal of the process info v3 APIs.

Copied from #88 (comment):

Version change:

495.46 -> 510.39.01: NVIDIA/nvidia-settings@b2f0e7f

  • Add process info v3 APIs but use v2 nvmlProcessInfo_st struct type

  • default:

    • nvmlDeviceGetComputeRunningProcesses -> nvmlDeviceGetComputeRunningProcesses_v3
    • nvmlProcessInfo_st -> nvmlProcessInfo_v2_st

530.41.03 -> 535.43.02: NVIDIA/nvidia-settings@39c3e28

  • Process info v3 APIs use v3 nvmlProcessInfo_st struct type without a version bump

  • default:

    • nvmlDeviceGetComputeRunningProcesses -> nvmlDeviceGetComputeRunningProcesses_v3
    • nvmlProcessInfo_st -> nvmlProcessInfo_v3_st

535.86.05 -> 535.98: NVIDIA/nvidia-settings@0cb3bef

  • Remove process info v3 APIs and v3 nvmlProcessInfo_st struct type

  • default:

    • nvmlDeviceGetComputeRunningProcesses -> nvmlDeviceGetComputeRunningProcesses_v2
    • nvmlProcessInfo_st -> nvmlProcessInfo_v2_st

UPDATE:

535.98 -> 535.104.05: NVIDIA/nvidia-settings@74cae7f

  • Re-add process info v3 APIs but use v2 nvmlProcessInfo_st struct type

  • default:

    • nvmlDeviceGetComputeRunningProcesses -> nvmlDeviceGetComputeRunningProcesses_v3
    • nvmlProcessInfo_st -> nvmlProcessInfo_v2_st

Motivation and Context

Fixes #88

@XuehaiPan XuehaiPan added bug Something isn't working upstream Something upstream related pynvml Something related to the `nvidia-ml-py` package api Something related to the core APIs labels Aug 16, 2023
@XuehaiPan XuehaiPan self-assigned this Aug 16, 2023
@XuehaiPan XuehaiPan changed the title fix(api/libnvml): fix upstream removal for process info v3 APIs on 535.98 driver fix(api/libnvml): fix removal for process info v3 APIs on the upstream 535.98 driver Aug 16, 2023
@XuehaiPan XuehaiPan linked an issue Aug 17, 2023 that may be closed by this pull request
3 tasks
@XuehaiPan XuehaiPan merged commit 6a9663b into main Aug 17, 2023
1 check passed
@XuehaiPan XuehaiPan deleted the fix-process-api branch August 17, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the core APIs bug Something isn't working pynvml Something related to the `nvidia-ml-py` package upstream Something upstream related
Projects
None yet
1 participant