feat: [LINKER-110] 프로필 헤더 수정 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danivelop
reviewed
Feb 8, 2024
| @@ -0,0 +1,27 @@ | |||
| import { useEffect, useState } from 'react'; | |||
|
|
|||
| const useIsScrolling = (y = 0) => { | |||
There was a problem hiding this comment.
hook이 하는 역할이 스크롤 위치가 인자로 받은 값을 넘었는지 여부를 나타내는것 같아서 useIsScorllOver, useScrollBoundary 같은 네이밍은 어떨까요?
There was a problem hiding this comment.
useIsScrollOver로 수정했습니다
Comment on lines
7
to
21
| const handleScroll = () => { | ||
| if (y < window.scrollY) { | ||
| setIsScrolling(true); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| setIsScrolling(false); | ||
| }; | ||
|
|
||
| window.addEventListener('scroll', handleScroll); | ||
|
|
||
| return () => { | ||
| window.removeEventListener('scroll', handleScroll); | ||
| }; |
There was a problem hiding this comment.
scroll이벤트시마다 리렌더링이 발생하며 성능상 저하가 발생할 수 있을것 같은데 실제로 scrollY가 인자값을 통과하는 시점에만 setIsScrolling을 호출하도록 개선해봐도 좋을것 같습니다!
현재 isScrolling에 대한 ref값만 하나 추가하면 구현 가능하지 않을까 싶네요
There was a problem hiding this comment.
useEffect dependency array로 인해서 scroll 이벤트마다 리렌더링이 발생하지 않습니닷
unmount 이후 인수값보다 낮아지지 않으면 scroll 이벤트가 발생하지 않는다는 테스트 코드 추가해두었어용
JjungminLee
reviewed
Feb 9, 2024
packages/lds/src/Icon/Icon.tsx
Outdated
| return ( | ||
| <Image | ||
| src={`${bucket}/icons/${name}.svg`} | ||
| alt={`${name} icon`} | ||
| width={size} | ||
| height={size} | ||
| height={height ?? size} |
There was a problem hiding this comment.
height와 size의 차이가 무엇인가요?!
useonglee
force-pushed
the
feat/LINKER-110
branch
from
f3994a8 to
dcdc8ab
Compare
JjungminLee
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
반영 화면
2024-02-08.6.06.42.mov
2024-02-08.6.07.00.mov
기타