-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [LINKER-106] Dropdown 컴포넌트 개발 #53
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4faf95e
feat: 플로팅버튼 컴포넌트 개발
JjungminLee 6311f73
fix: css 짜잘 수정
JjungminLee 6d9ad41
fix: 한개의 아이템당 하나의 플로팅버튼으로 수정
JjungminLee f075ba8
feat: 일정상세 플로팅버튼 연결
JjungminLee 1c5ee6a
fix: 타입체크 수정
JjungminLee 529df85
fix: pr코멘트 기반 반영
JjungminLee 43dcc72
fix: 다크모드 반영
JjungminLee acbb77d
style: FloatingItem->Floating Item 변수명 변경
JjungminLee 02ea566
refactor: Omit삭제
JjungminLee 884fb3a
fix: API필드 일치시키기 + contextAPI 원복
JjungminLee 6fcca29
fix: 연락처 API 필드 맞추기
JjungminLee 8f9d6ad
fix: ContactsSearch.tsx API필드에 맞춰 변경
JjungminLee 30a16cb
feat: 삭제하기 API연결
JjungminLee 52fc276
feat: 검색화면 퍼블리싱
JjungminLee f5202ec
style: 검색화면 css수정
JjungminLee 25d35fe
refactor: 삭제하기 API연결
JjungminLee bd836f1
refactor: 헤드리스 디자인패턴으로 드롭다운 수정
JjungminLee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { HTMLAttributes } from 'react'; | ||
import { ReactNode } from 'react'; | ||
|
||
import FloatingItem from './DropdownItem'; | ||
|
||
interface BaseProps extends Omit<HTMLAttributes<HTMLButtonElement>, 'type'> { | ||
children: ReactNode; | ||
className?: string; | ||
} | ||
const Dropdown = ({ children, className }: BaseProps) => { | ||
return <div className={className}>{children}</div>; | ||
}; | ||
|
||
export default Object.assign(Dropdown, { Item: FloatingItem }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FloatingItem -> DropdownItem |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,8 @@ import { colors } from '@linker/styles'; | |
import { ReactNode } from 'react'; | ||
import { HTMLAttributes } from 'react'; | ||
|
||
import { container } from './FloatingItem.css'; | ||
import { Txt } from '../../Txt'; | ||
import { container } from './DropdownItem.css'; | ||
import { Txt } from '../Txt'; | ||
|
||
interface Props extends Omit<HTMLAttributes<HTMLButtonElement>, 'type'> { | ||
text: string; | ||
|
@@ -12,7 +12,7 @@ interface Props extends Omit<HTMLAttributes<HTMLButtonElement>, 'type'> { | |
} | ||
// 플로팅 버튼의 두가지 종류 -> 오른쪽이 아이콘, 오른쪽이 원 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 주석은 제거해도 될 것 같아요 |
||
|
||
const FloatingItem = ({ text, rightAddon }: Props) => { | ||
const DropdownItem = ({ text, rightAddon }: Props) => { | ||
return ( | ||
<div className={container}> | ||
<Txt typography="p3" fontWeight="regular" color={colors.gray900}> | ||
|
@@ -23,4 +23,4 @@ const FloatingItem = ({ text, rightAddon }: Props) => { | |
); | ||
}; | ||
|
||
export default FloatingItem; | ||
export default DropdownItem; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default as Dropdown } from './Dropdown'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omit은 제거해도 될 것 같아유