[Feature/BAR-139] Tooltip 컴포넌트 구현 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmswl98 |
miro-ring
reviewed
Jan 6, 2024
wonjin-dev
reviewed
Jan 7, 2024
|
|
||
| useEffect(() => { | ||
| if (tooltipRoot) { | ||
| document.body.appendChild(tooltipRoot); |
There was a problem hiding this comment.
굉장히 기분탓이지만 리액트에서 동적으로 돔을 조작하는게 조금 거부감이 느껴지네요..
There was a problem hiding this comment.
@wonjin-dev @dongkyun-dev
저도 그렇게 생각해요..🥲
우선 merge 후에 새로운 PR에서
- DOM을 직접 조작하지 않는 Portal 공통 컴포넌트를 구현하고,
- Modal과 Tooltip 컴포넌트에 적용하는 작업을 이어서 하겠습니다!
miro-ring
approved these changes
Jan 8, 2024
|
@dongkyun-dev @wonjin-dev 추가로 작업한 부분은 |
고생하셧습니다 ㅎㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Reviewers
z-indextoken도 상수화해두었는데 값이 적절한지 확인해주세요.How To Test