-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/BAR-225] 맞춤법 검사 결과 카드 UI 구현 #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pages/api/spell-check.ts
Outdated
let correction = sentence; | ||
|
||
suggestions.forEach(({ errorToken, correct }) => { | ||
const regex = new RegExp(`${errorToken}`, 'g'); | ||
correction = correction.replace(regex, correct); | ||
}); | ||
|
||
return correction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduce를 사용해서 정리할 수 있지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5e3bfae 반영해두었습니다!
src/assets/icons/Bookmark.tsx
Outdated
@@ -0,0 +1,17 @@ | |||
import type { SVGProps } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 형태로 사용하는게 더 편하신가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fc8df1c svg로 변경해두었습니다!
import { type SpellCheckResponse } from '../../../../../api/spell/types'; | ||
import { usePostSpellCheck } from '../../../../../queries/useSpellCheck'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이렇게 뎁스 깊어지는건 절대경로 사용하면 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
308cc12 적용해두었습니다!
import { COLORS } from '@styles/tokens'; | ||
|
||
export const icon = style({ | ||
transition: 'all 100ms ease-in-out', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fill 속성에만 적용해도 괜찮을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ec5b8b2 적용해두었습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셧습니다!
Summary
To Reviewers
2024-02-06.10.47.03.mov
How To Test