[Fix/BAR-248] 로그인 이슈 해결 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmswl98 |
dmswl98
approved these changes
Feb 22, 2024
| @@ -13,12 +15,17 @@ interface HeaderProps { | |||
| } | |||
|
|
|||
| const Header = ({ type }: HeaderProps) => { | |||
| const refreshToken = Cookies.get(STORAGE_KEY.REFRESH_TOKEN); | |||
|
|
|||
| const HeaderButtonGroup = () => | |||
| type === 'intro' ? <LoginButton /> : <UserButton />; | |||
There was a problem hiding this comment.
요기도 intro 대신 landing으로 통일하면 좋겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Reviewers
7a57b18
2d47c93
기존에 미들웨어를 통해 처리하고자 했습니다. 알고보니 미들웨어는 nginx와 비슷한 기능을 하는 요소더라고요. 즉 외부 도메인 진입시에 동작하는 로직이고 내부에서 router를 통해 이동할 때는 해당 구문을 거치지 않습니다. 때문에 내부적으로 분기를 태워서 이동할 페이지 위치를 정하도록 수정합니다.
ba630fd
랜딩 페이지 이미지가 꺠지는 문제가 있어 svg로 교체합니다.
How To Test