[Fix/BAR-250] 폴더 삭제 에러 해결 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miro-ring
approved these changes
Feb 23, 2024
src/components/Button/style.css.ts
Outdated
Comment on lines
10
to
12
| ':disabled': { | ||
| cursor: 'not-allowed', | ||
| }, |
There was a problem hiding this comment.
보통 not-allowed 처리 안하지 않나요?? 디자인쪽 니즈인가요?
There was a problem hiding this comment.
7294d1f 하는게 더 명확해보일거라 생각했는데 실무에서는 잘 모르겠네요ㅎㅎ
src/components/Card/index.tsx
Outdated
Comment on lines
65
to
73
| return ( | ||
| <> | ||
| {!defaultIsVisibleMenu ? ( | ||
| isVisibleMenu && <div className={styles.menu}>{children}</div> | ||
| ) : ( | ||
| <div className={styles.menu}>{children}</div> | ||
| )} | ||
| </> | ||
| ); |
There was a problem hiding this comment.
if (!defaultIsVisibleMenu && !isVisibleMenu) return null;
return <div></div>해당 형태가 더 깔끔할 것 같아요!
There was a problem hiding this comment.
해당 부분 이렇게 수정해두었습니다~
return (
<>
{(defaultIsVisibleMenu || isVisibleMenu) && (
<div className={styles.menu}>{children}</div>
)}
</>
); | @@ -16,10 +16,11 @@ interface CardProps { | |||
| | 'grey' | |||
| | 'white'; | |||
| className?: string; | |||
| defaultIsVisibleMenu?: boolean; | |||
There was a problem hiding this comment.
boolean 타입의 변수명이 아래쪽에서 is로 시작해서 이 변수명도 is로 시작해도 좋을 것 같아요
There was a problem hiding this comment.
고것도 고민해봤는데 default가 중간에 들어가면 네이밍이 어색할 거 같았고 IsVisibleMenu가 뭉쳐있어야 이해하기 쉬울 것 같아 요렇게 해두었습니다..!
Comment on lines
+49
to
+54
| onMouseEnter={() => { | ||
| !defaultIsVisibleMenu && onShow(); | ||
| }} | ||
| onMouseLeave={() => { | ||
| !defaultIsVisibleMenu && onHide(); | ||
| }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Reviewers
How To Test