[UI/YAF-117] 설정 UI Component를 구현합니다. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
reviewed
Feb 8, 2025
Comment on lines
62
to
80
| Row( | ||
| verticalAlignment = Alignment.CenterVertically, | ||
| ) { | ||
| Text( | ||
| text = actionTitle ?: "", | ||
| style = OrbitTheme.typography.body1Medium, | ||
| color = if (isPressed) OrbitTheme.colors.main else OrbitTheme.colors.gray_500, // ✅ Press 상태일 때만 색상 변경 | ||
| modifier = Modifier | ||
| .padding(horizontal = 8.dp, vertical = 4.dp) | ||
| .clickable( | ||
| interactionSource = interactionSource, | ||
| indication = null, | ||
| onClick = { /* TODO: 클릭 이벤트 */ }, | ||
| ), | ||
| ) | ||
| Spacer(modifier = Modifier.width(20.dp)) | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
[p4]
Spacer(modifier = Modifier.width(20.dp)) 보다
Row(modifier = Modifier.padding(end = 20.dp)) 가 더 나을수도??
DongChyeon
reviewed
Feb 8, 2025
There was a problem hiding this comment.
[p5]
궁금한건데 그냥 Modifier 기본값이 아닌 Modifier.wrapContentWidth()를 사용할 때의 이점이 뭔가요?
There was a problem hiding this comment.
XML에 뇌가 절여져서... 버릇이 됐습니다..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #99
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢