[FEAT/YAF-116] 알림이 울릴 때 해제 혹은 미루기가 가능한 UI를 표시한다 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonsuKang
reviewed
Feb 9, 2025
Comment on lines
120
to
138
| val backgroundStrokePx = backgroundWidth.toPx() | ||
| val progressStrokePx = progressWidth.toPx() | ||
|
|
||
| val offset = (backgroundStrokePx - progressStrokePx) / 2 | ||
|
|
||
| val backgroundColor = Color.White.copy(alpha = 0.2f) | ||
|
|
||
| val progressBlurEffect = BlurMaskFilter( | ||
| progressBlurRadius.toPx(), | ||
| BlurMaskFilter.Blur.NORMAL, | ||
| ) | ||
|
|
||
| val progressPaint = Paint().apply { | ||
| color = OrbitTheme.colors.main.toArgb() | ||
| maskFilter = progressBlurEffect | ||
| style = Paint.Style.STROKE | ||
| strokeWidth = progressStrokePx | ||
| strokeCap = Paint.Cap.ROUND | ||
| } |
There was a problem hiding this comment.
p3
이거 Canvas의 draw Scope범위 내로 옮기는게 좋지 않을까요?
toPx같은 경우는 Density에 의존하게 되는데 Canvas의 Scope 내부에서는 이미 Density 컨텍스트가 설정되어 있어서, toPx 변환이 더 최적화될 수 있을 것 같다고 생각해서요!
| totalSeconds = 300, | ||
| ) | ||
|
|
||
| Spacer(modifier = Modifier.weight(1f)) |
There was a problem hiding this comment.
p4
이거 빼고
Column(
verticalArrangement = Arrangement.SpaceBetween
)
로 해서 같은 결과라면, 이게 더 좋은 구조일 것 같습니다!
There was a problem hiding this comment.
Arrangement.SpaceBetween은 해당 공간을 최대로 활용하되 안에 있는 요소들간 일정 간격을 유지하게 하는 것이라서...
사용하지 못할 것 같습니다.
| private fun formatSecondsToTime(seconds: Int): String { | ||
| val minutes = seconds / 60 | ||
| val remainingSeconds = seconds % 60 | ||
| return String.format(Locale.getDefault(), "%02d:%02d", minutes, remainingSeconds) |
There was a problem hiding this comment.
p4
val locale = Locale.getDefault()
There was a problem hiding this comment.
locale을 여러 곳이 아니라 한 곳에서만 사용한다면 inline variable이라도 상관없다는 생각
There was a problem hiding this comment.
매번 Locale.getDefault()를 호출하는 대신
toString().padStart()를 활용하도록 변경했습니다.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #89
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
2025-02-09.2.00.17.mov
Uncompleted Tasks 😅
N/A
To Reviewers 📢
자기 전에 깃허브에서 여러 알람앱을 찾아봤는데 결국에는 알람 해제 액티비티를 따로 분리해야할 것 같아요
그래서 추후에 AlarmAction, AlarmSnoozeTimer는 따로 모듈화 예정입니다.