[FEAT/YAF-000] 사용자 등록/조회 연결을 진행합니다. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
reviewed
Feb 12, 2025
| private val apiService: ApiService, | ||
| ) : UserInfoDataSource { | ||
| override suspend fun getUserInfo(userId: Long): Result<UserResponse> { | ||
| return safeApiCall { apiService.getUserInfo(userId) } |
There was a problem hiding this comment.
제가 좋아하는 명언이 있습니다.
"예외처리는 성능때문에 뺐다" 라는 말인데요. 그래서 저도 뺐습니다. 라고하면 안되겠죠~? ㅋㅋ
safeApiCall 내부에서 예외가 발생하면 Result.failure(exception)이 반환되는 구조라 예외처리를 안했는데. 생각해보니까
성공해도 body가 null로 넘어올때의 예외처리를 해야될 것 같네용 아닌가? null이 오는 경우가 없나요? 허,,
default.mp4오류 발견이용.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #110
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢