-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 알람 해제 UX 개선 및 알람 권한 요청 #116
Conversation
…미 AlarmInteractionActivity에 있는 상태에서 푸시 알림을 클릭했을 때)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOOD
var hasRequestedPermission by remember { mutableStateOf(false) } | ||
var hasCheckedNotification by remember { mutableStateOf(false) } | ||
var hasCheckedAlarm by remember { mutableStateOf(false) } | ||
|
||
var isAlarmPermissionGranted by remember { mutableStateOf(false) } | ||
|
||
var hasDelayed by remember { mutableStateOf(false) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p4
rememberSaveable이 더 났지 않을까염?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그런듯여
} else if (!isAlarmPermissionGranted && Build.VERSION.SDK_INT >= Build.VERSION_CODES.S && !hasCheckedAlarm) { | ||
hasCheckedAlarm = true | ||
val intent = Intent(Settings.ACTION_REQUEST_SCHEDULE_EXACT_ALARM).apply { | ||
data = Uri.fromParts("package", context.packageName, null) | ||
} | ||
context.startActivity(intent) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5
Dispatchers.Main으로 처리하는거 어떻게 생각하세요? 궁금함
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그건 몰띾넹
4793cfe
to
902d33c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤡
Related issue 🛠
closed #115
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
default.mp4
알람 해제
클릭 시 AlarmInteractionActivity 종료Uncompleted Tasks 😅
N/A
To Reviewers 📢
SCHEDULE_EXACT_ALARM
권한이 Accompanist Permission과 호환이 안되서 쌩으로 구현했습니다...설정창에서 다시 앱으로 돌아왔을 때 권한을 체크해줘야 하는데, LaunchedEffect로는 처리가 안되길래
LifecycleEventObserver로 onResumse 상태가 될 때마다 검사했습니다.
실제로 LifeCycleObserver가 재등록된 후에는 작동하지 않았습니다.
LaunchedEffectWithLifeCycle은 해당 문제로 인해 삭제했습니다~