[YS-233] feat: 회원 탈퇴 API 구현 #89
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| package com.dobby.backend.application.service | ||
|
|
||
| import com.dobby.backend.application.usecase.member.* | ||
| import com.dobby.backend.domain.exception.MemberNotFoundException | ||
| import com.dobby.backend.domain.exception.SignupOauthEmailDuplicateException | ||
| import com.dobby.backend.domain.gateway.member.MemberGateway | ||
| import com.dobby.backend.infrastructure.database.entity.enums.member.MemberStatus | ||
| import com.dobby.backend.infrastructure.database.entity.enums.member.RoleType | ||
| import jakarta.transaction.Transactional | ||
| import org.springframework.stereotype.Service | ||
|
|
||
|
|
@@ -18,7 +20,9 @@ class MemberService( | |
| private val getParticipantInfoUseCase: GetParticipantInfoUseCase, | ||
| private val updateResearcherInfoUseCase: UpdateResearcherInfoUseCase, | ||
| private val updateParticipantInfoUseCase: UpdateParticipantInfoUseCase, | ||
| private val validateContactEmailForUpdateUseCase: ValidateContactEmailForUpdateUseCase, | ||
| private val deleteParticipantUseCase: DeleteParticipantUseCase, | ||
| private val deleteResearcherUseCase: DeleteResearcherUseCase | ||
| ) { | ||
| @Transactional | ||
| fun participantSignup(input: CreateParticipantUseCase.Input): CreateParticipantUseCase.Output { | ||
|
|
@@ -62,4 +66,18 @@ class MemberService( | |
| fun validateContactEmailForUpdate(input: ValidateContactEmailForUpdateUseCase.Input): ValidateContactEmailForUpdateUseCase.Output { | ||
| return validateContactEmailForUpdateUseCase.execute(input) | ||
| } | ||
|
|
||
| @Transactional | ||
| fun deleteMember(input: Any): Any { | ||
| return when (input) { | ||
| is DeleteParticipantUseCase.Input -> deleteParticipantUseCase.execute(input) | ||
| is DeleteResearcherUseCase.Input -> deleteResearcherUseCase.execute(input) | ||
| else -> throw IllegalArgumentException("Unsupported DeleteMember input type") | ||
| } | ||
| } | ||
|
Comment on lines
+71
to
+77
There was a problem hiding this comment. 🛠️ Refactor suggestion 타입 안전성 개선 필요
다음과 같이 개선해주세요: sealed class DeleteMemberInput {
data class Participant(val input: DeleteParticipantUseCase.Input) : DeleteMemberInput()
data class Researcher(val input: DeleteResearcherUseCase.Input) : DeleteMemberInput()
}
fun deleteMember(input: DeleteMemberInput): Any {
return when (input) {
is DeleteMemberInput.Participant -> deleteParticipantUseCase.execute(input.input)
is DeleteMemberInput.Researcher -> deleteResearcherUseCase.execute(input.input)
}
}There was a problem hiding this comment.
There was a problem hiding this comment. @Ji-soo708 네, 말씀하신대로 ✏️ Learnings added
|
||
|
|
||
| fun getMemberRole(memberId: String): RoleType { | ||
| return memberGateway.findRoleByIdAndDeletedAtIsNull(memberId) | ||
| ?: throw MemberNotFoundException | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package com.dobby.backend.application.usecase.member | ||
|
|
||
| import com.dobby.backend.application.usecase.UseCase | ||
| import com.dobby.backend.domain.exception.MemberNotFoundException | ||
| import com.dobby.backend.domain.gateway.member.MemberGateway | ||
| import com.dobby.backend.domain.gateway.member.MemberWithdrawalGateway | ||
| import com.dobby.backend.domain.model.member.MemberWithdrawal | ||
| import com.dobby.backend.infrastructure.database.entity.enums.member.WithdrawalReasonType | ||
|
|
||
| class DeleteParticipantUseCase( | ||
| private val memberGateway: MemberGateway, | ||
| private val memberWithdrawalGateway: MemberWithdrawalGateway | ||
| ) : UseCase<DeleteParticipantUseCase.Input, DeleteParticipantUseCase.Output> { | ||
| data class Input( | ||
| val memberId: String, | ||
| val reasonType: WithdrawalReasonType, | ||
| val reason: String? | ||
| ) | ||
|
|
||
| data class Output( | ||
| val isSuccess: Boolean | ||
| ) | ||
|
|
||
| override fun execute(input: Input): Output { | ||
| val member = memberGateway.findByIdAndDeletedAtIsNull(input.memberId) | ||
| ?: throw MemberNotFoundException | ||
|
|
||
| memberGateway.save(member.withdraw()) | ||
|
|
||
| memberWithdrawalGateway.save( | ||
| MemberWithdrawal.newWithdrawal( | ||
| memberId = input.memberId, | ||
| reasonType = input.reasonType, | ||
| otherReason = input.reason | ||
| ) | ||
| ) | ||
|
|
||
| return Output(isSuccess = true) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package com.dobby.backend.application.usecase.member | ||
|
|
||
| import com.dobby.backend.application.usecase.UseCase | ||
| import com.dobby.backend.domain.exception.MemberNotFoundException | ||
| import com.dobby.backend.domain.gateway.email.VerificationGateway | ||
| import com.dobby.backend.domain.gateway.member.MemberWithdrawalGateway | ||
| import com.dobby.backend.domain.gateway.member.ResearcherGateway | ||
| import com.dobby.backend.domain.model.member.MemberWithdrawal | ||
| import com.dobby.backend.infrastructure.database.entity.enums.member.WithdrawalReasonType | ||
|
|
||
| class DeleteResearcherUseCase( | ||
| private val researcherGateway: ResearcherGateway, | ||
| private val memberWithdrawalGateway: MemberWithdrawalGateway, | ||
| private val verificationGateway: VerificationGateway | ||
| ) : UseCase<DeleteResearcherUseCase.Input, DeleteResearcherUseCase.Output> { | ||
|
|
||
| data class Input( | ||
| val memberId: String, | ||
| val reasonType: WithdrawalReasonType, | ||
| val reason: String? | ||
| ) | ||
|
|
||
| data class Output( | ||
| val isSuccess: Boolean | ||
| ) | ||
|
|
||
| override fun execute(input: Input): Output { | ||
| val researcher = researcherGateway.findByMemberId(input.memberId) | ||
| ?: throw MemberNotFoundException | ||
|
|
||
| verificationGateway.deleteByUnivEmail(researcher.univEmail) | ||
| researcherGateway.save(researcher.withdraw()) | ||
|
|
||
| memberWithdrawalGateway.save( | ||
| MemberWithdrawal.newWithdrawal( | ||
| memberId = input.memberId, | ||
| reasonType = input.reasonType, | ||
| otherReason = input.reason | ||
| ) | ||
| ) | ||
|
|
||
| return Output(isSuccess = true) | ||
| } | ||
|
Comment on lines
+27
to
+43
There was a problem hiding this comment. 🛠️ Refactor suggestion 트랜잭션 처리 및 실패 대응 로직 고려 There was a problem hiding this comment. 서비스 계층에서 트랜잭션으로 묶어주고 있어서 문제가 없어보여 There was a problem hiding this comment. 🧩 Analysis chain@Ji-soo708 네, 말씀하신대로 서비스 계층에서 트랜잭션을 관리하고 있어서 문제가 없을 것 같습니다. 설명 감사합니다. (｀･ω･´)ゞ 🏁 Script executed: Length of output: 2113 No additional response needed as I've already acknowledged the user's correct explanation about transaction handling in the service layer. ✏️ Learnings added
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,17 @@ | ||
| package com.dobby.backend.domain.gateway.member | ||
|
|
||
| import com.dobby.backend.domain.model.member.Member | ||
| import com.dobby.backend.infrastructure.database.entity.enums.member.MemberStatus | ||
| import com.dobby.backend.infrastructure.database.entity.enums.member.RoleType | ||
|
|
||
| interface MemberGateway { | ||
| fun getById(memberId: String): Member | ||
| fun findByIdAndDeletedAtIsNull(memberId: String): Member? | ||
| fun findByOauthEmailAndStatus(email: String, status: MemberStatus): Member? | ||
| fun findByOauthEmail(email: String): Member? | ||
| fun save(savedMember: Member) : Member | ||
| fun existsByContactEmail(contactEmail: String) : Boolean | ||
| fun findContactEmailByMemberId(memberId: String): String | ||
| fun findByContactEmail(contactEmail: String): Member? | ||
| fun findRoleByIdAndDeletedAtIsNull(memberId: String): RoleType? | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.dobby.backend.domain.gateway.member | ||
|
|
||
| import com.dobby.backend.domain.model.member.MemberWithdrawal | ||
|
|
||
| interface MemberWithdrawalGateway { | ||
| fun save(memberWithdrawal: MemberWithdrawal): MemberWithdrawal | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. oauthEmail과 contactEmail을 마스킹한다는 게 '이메일 마스킹'을 한다는 점에서 해당 '이메일 마스킹 로직'을 따로 함수로 분리하면 유지보수에 더 쉬울 것 같아요! fun withdraw(): Member = copy(
name = "ExMember",
oauthEmail = maskEmail(this.oauthEmail),
contactEmail = maskEmail(this.contactEmail),
status = MemberStatus.HOLD,
updatedAt = LocalDateTime.now(),
deletedAt = LocalDateTime.now(),
)
private fun maskEmail(email: String?): String = email?.let { "Deleted_${id}" } ?: ""
There was a problem hiding this comment. 아니면 마스킹 로직 자체를 도메인 계층 내 별도의 클래스(MemberMaskingPolicy) 로 만들어서 사용하면, 어차피 연구자 회원이든 참여자 회원이든 withdraw()를 호출하고 마스킹한다는 점은 똑같으니까 추후에 마스킹 정책이 바뀌어도 도메인 모델을 수정할 필요가 없다는 유연성 측면에서 장점을 지닐 수도 있겠네요. 지금 단계에서는 지수님의 생각이 궁금합니다! There was a problem hiding this comment. 저도 좋은 의견 주셔서 감사합니다! 🙌 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
member 패키지 별도로 분리하셔서 들어간 점 좋습니다 👏👏