Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TnT-64] 디자인 시스템 구현 #11

Merged
merged 5 commits into from
Jan 5, 2025
Merged

[TnT-64] 디자인 시스템 구현 #11

merged 5 commits into from
Jan 5, 2025

Conversation

SeonJeongk
Copy link
Contributor

📝 작업 내용

  • Closes [TNT-64] 디자인 시스템 구현 #3

  • 현재 나온 디자인 시스템을 바탕으로 구현했습니다

  • Color

    • 디자인 시스템 기반 색상 팔레트 정의

  • Typo

    • Pretendard 폰트를 사용한 기본 텍스트 스타일 정의
    • Material3의 Typography 객체를 활용하여 텍스트 스타일 구현

📸 실행 화면

  • x

🙆🏻 리뷰 요청 사항

  • 없습니다

👀 레퍼런스

@SeonJeongk SeonJeongk added 🎨 Design UI 및 디자인 작업 🌻 선정 김씨 집안 막내 김선정 labels Jan 4, 2025
@SeonJeongk SeonJeongk self-assigned this Jan 4, 2025
hoyahozz
hoyahozz approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@hoyahozz hoyahozz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귀찮은 작업이셨을텐데 너무 고생 많으셨어요 ㅎㅎ

CI 미통과 원인은 ktlint 에서 캐치한 트레일링 콤마 때문인 것 같아요! 요 부분만 수정 부탁드릴게요 ㅎㅎ

(Auto assign, PR 리뷰 알림 관련 actions 는 한 번 제가 수정해두겠습니다 😭 )

core/designsystem/src/main/java/co/kr/tnt/designsystem/theme/Color.kt Outdated
Comment on lines 13 to 18
// Text Color
val Text_Normal = Color(0xFF0A0A0A)
val Text_Strong = Color(0xFF171717)
val Text_Neutral = Color(0xFF404040)
val Text_Alternative = Color(0xFF737373)
val Text_Disable = Color(0xFFD4D4D4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 생각에 요친구들은 화면 백그라운드 모드에 따라 변경될 수 있는 시멘틱 컬러로 보여요 !_!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 삭제해두겠습니다!

@hoyahozz hoyahozz self-requested a review January 5, 2025 07:10
@hoyahozz hoyahozz self-requested a review January 5, 2025 07:12
hoyahozz
hoyahozz approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@hoyahozz hoyahozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve PR - 디스코드 연동 테스트

@SeonJeongk SeonJeongk merged commit 471b6eb into develop Jan 5, 2025
10 checks passed
@SeonJeongk SeonJeongk deleted the design/TNT-64 branch January 5, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoyahozz hoyahozz hoyahozz approved these changes

Assignees

@SeonJeongk SeonJeongk

Labels
🌻 선정 김씨 집안 막내 김선정 🎨 Design UI 및 디자인 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TNT-64] 디자인 시스템 구현
2 participants
@SeonJeongk @hoyahozz