[TNT-189] 트레이니 알림 화면 UI 구현 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyahozz
reviewed
Feb 3, 2025
| import java.time.temporal.ChronoUnit | ||
| import java.util.Locale | ||
|
|
||
| object NotificationTimeUtil { |
There was a problem hiding this comment.
시간에 따라 어떻게 출력할지 결정하는건, 도메인에 위치하는 것보단 프레젠테이션단에 위치하는게 좀 더 자연스러워 보여요!
There was a problem hiding this comment.
이게 정책일지 아닐지 고민했는데 아무래도 화면에 출력할 형식이니까 프레젠테이션단이 자연스럽겠죠?!
core:ui의 util로 옮겨두겠습니다 👍
hoyahozz
approved these changes
Feb 3, 2025
| val type: NotificationType, | ||
| val title: String, | ||
| val contents: String, | ||
| val time: String, |
There was a problem hiding this comment.
요기서 time 은 LocalDate 형태일 것 같습니당!
There was a problem hiding this comment.
엇 요걸 놓쳤네요 수정해두겠습니다!
There was a problem hiding this comment.
시간까지 다뤄야 하기 때문에 LocalDateTime으로 수정해뒀습니다!
| import java.time.temporal.ChronoUnit | ||
| import java.util.Locale | ||
|
|
||
| object NotificationTimeUtil { |
There was a problem hiding this comment.
음 요거 생각해보니 알림 화면에서만 쓸 친구같아서, 싱글톤으로 선언하면 안될 것 같아요!
일반 클래스로 선언하고, NotificationTimeFormatter 정도로 네이밍 지으면 좋을 것 같습니돠!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
[TNT-189] 트레이니 알림 화면 구현 #52
이전 PR 리뷰 반영 안 된 부분 수정
알림 컴포넌트 구현
트레이니 알림 화면 UI 구현
트레이니 알림은 클릭이 불가능하기 때문에 화면에 알림만 보여주도록 구현했습니다
알림이 없을 경우 "최근 받은 알림이 없어요" 를 화면 중앙에 보여주고 있습니다
도메인의
NotificationInfo에서type은 API가 나오면 그에 맞춰서 다시 수정해보겠습니다..!📸 실행 화면
알림이 없는 경우
알림 스크롤
trainee_notification.mp4
🙆🏻 리뷰 요청 사항
없습니다!
👀 레퍼런스