Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1 - Issue,PullRequest Template 추가, Discord 봇 설정 #2

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Conversation

kpeel5839
Copy link
Contributor

#1 해당 이슈 참고하시면 될 것 같아용~

@kpeel5839 kpeel5839 requested a review from sectionr0 June 17, 2024 04:51
@kpeel5839 kpeel5839 self-assigned this Jun 17, 2024
@sectionr0
Copy link
Contributor

pullRequestTemplate 내용을 조금 더 상세하게 하면 어떠실까요?!

제가 이전에 했던 PR Template 방식이 있는데 이렇게 더 다양하게 해보시는건 어떨까요??

의견 남겨주세요~!!

@kpeel5839
Copy link
Contributor Author

pullRequestTemplate 내용을 조금 더 상세하게 하면 어떠실까요?!

제가 https://github.com/shophubkr/shophub-server/pull/66이 있는데 이렇게 더 다양하게 해보시는건 어떨까요??

의견 남겨주세요~!!

좋아용 이렇게 바꿀께용

@kpeel5839 kpeel5839 changed the title [chore] Issue,PullRequest Template 추가, Discord 봇 설정 #1 - Issue,PullRequest Template 추가, Discord 봇 설정 Jun 17, 2024
Copy link
Contributor

@sectionr0 sectionr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

너무너무 고생하셨습니다!

@sectionr0 sectionr0 self-requested a review June 17, 2024 15:34
@github-actions github-actions bot added the 🌟머지 해주세요🌟 머지해주셔! label Jun 17, 2024
@sectionr0 sectionr0 merged commit d98a056 into main Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants