Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24기] 24기 모집 전 공식 웹 수정 사항 반영 #156

Merged
merged 19 commits into from
Apr 5, 2024

Conversation

youngminss
Copy link
Collaborator

@youngminss youngminss commented Apr 4, 2024

📘 작업 유형

  • 신규 기능 추가
  • 버그 수정

📑 작업리스트

1. IntroSection - 24기 배너 컴포넌트 생성

23기 때는 video 로 대체했었는데 24기 때는 당시 리소스 문제로 이미지 리소스만 받고 조금의 애니메이션만 추가해서 진행했었습니다.

PC 예시 Tablet 예시 Mobile 예시
banner-pc-ex banner-tablet-ex banner-mobile-ex

2. 버그 수정

  1. Project 팀 종류 필터 섹션 스크롤 바 노출 현상
AS-IS TO-BE
project-scroll-before project-scroll-after
  • global-style.css 파일에 크로스 브라우징 관련 scroll-bar hide 클래스 추가하여 필요한 곳에 적용함

🚧 특이 사항

  1. database 변경사항이 대부분입니다.
  2. 나머지는 파일 변경사항들은 lint 로 인해 import 순서 변경, 팔레트 추가, 이미지 에셋 추가 작업 변경사항입니다.

@youngminss youngminss added the feature New feature or request label Apr 4, 2024
@youngminss youngminss requested a review from Sangjun-man April 4, 2024 17:28
@youngminss youngminss self-assigned this Apr 4, 2024
@auto-assign auto-assign bot requested review from ojj1123 and useonglee April 4, 2024 17:28
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 14.9%, saving 190.62 KB.

Filename Before After Improvement Visual comparison
public/assets/images/og_24th.png 115.00 KB 104.32 KB -9.3% View diff
public/assets/project/23_content_yeobee.png 1.09 MB 947.15 KB -15.4% View diff
public/assets/sponsors/sponsor_greeting.png 40.96 KB 33.17 KB -19.0% View diff

128 images did not require optimisation.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 92.7%, saving 2.27 MB.

Filename Before After Improvement Visual comparison
public/assets/images/24th/banner-mobile.webp 217.93 KB 23.20 KB -89.4% View diff
public/assets/images/24th/banner-pc.webp 1.36 MB 91.01 KB -93.4% View diff
public/assets/images/24th/banner-tablet.webp 898.52 KB 67.59 KB -92.5% View diff

132 images did not require optimisation.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 3.5%, saving 6.29 KB.

Filename Before After Improvement Visual comparison
public/assets/images/24th/banner-mobile.webp 23.20 KB 22.40 KB -3.4% View diff
public/assets/images/24th/banner-pc.webp 91.01 KB 87.58 KB -3.8% View diff
public/assets/images/24th/banner-tablet.webp 67.59 KB 65.54 KB -3.0% View diff

132 images did not require optimisation.

@youngminss youngminss merged commit 226a8d6 into develop Apr 5, 2024
@youngminss youngminss deleted the feature/update-for-24th branch April 5, 2024 14:27
@youngminss youngminss added feature New feature or request and removed feature New feature or request labels Apr 5, 2024
@youngminss youngminss changed the title [feature] 24기 모집 전 공식 웹 수정 사항 반영 feat: 24기 모집 전 공식 웹 수정 사항 반영 Apr 16, 2024
@youngminss youngminss changed the title feat: 24기 모집 전 공식 웹 수정 사항 반영 [24기] 24기 모집 전 공식 웹 수정 사항 반영 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant