Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in pubspec files #14

Merged
merged 2 commits into from
Sep 28, 2024
Merged

change in pubspec files #14

merged 2 commits into from
Sep 28, 2024

Conversation

bhargavraviya
Copy link
Contributor

Flutter Upgrade from scratch

  • change pubspec new packages
  • sdk version changes for ^3.5.3
  • change minor text changes

please check it and merge @YC

@YC YC self-requested a review September 28, 2024 08:01
.gitignore Outdated
@@ -29,7 +30,7 @@
.packages
.pub-cache/
.pub/
build/
/build/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build/ should cover /build/.
Was this from flutter migrate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create a new Flutter project, these files generate automatically, including the .gitignore file.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually has to be build/ because of nested projects.

analysis_options.yaml Outdated Show resolved Hide resolved
pubspec.yaml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you create a new Flutter project, these files generate automatically, including the .gitignore file.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The templates have trailing newlines.

@YC YC self-requested a review September 28, 2024 08:57
@YC YC merged commit 2cd6bcf into YC:main Sep 28, 2024
1 check passed
@bhargavraviya bhargavraviya deleted the change-pubspec branch September 28, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants