Add pitch smoothing #98
Conversation
khanghugo
force-pushed
the
pitch_override
branch
from
b6a4ef3 to
b5b70ac
Compare
|
Waiting for hltas update. I think it is okay if it just works for global smoothing but not individual hovered segment. |
| let yaw = yaw.to_degrees(); | ||
| write!(&mut line, " {yaw}").unwrap(); | ||
| } | ||
|
|
||
| let op = Operation::Insert { line_idx: 0, line }; | ||
| self.apply_operation(op)?; | ||
|
|
||
| let mut line = "pitch_override".to_string(); |
There was a problem hiding this comment.
If the pitch was constant then it probably doesn't need to be smoothed? Also do you generally want to smooth both at once?
There was a problem hiding this comment.
I am not sure how I would change existing functions to stop working for stream of constant pitch. It just seems a lot easier to mirror it and just works. I see what you mean about second point where someone might just want to smooth the yaw. However, they can delete it easily. Also, adding another option to smooth pitch might be inconvenient as if soneone wants smoothing, just smooth it.
|
If anything can merge #101 before merging this. |
khanghugo
force-pushed
the
pitch_override
branch
from
090b8c2 to
15fbcc1
Compare
|
Rebased. I tested with one long TAS run I have and there's no problems. |
|
Thanks for testing. |
No description provided.