Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve circle dimen layer in 19+ devices #455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve circle dimen layer in 19+ devices #455

wants to merge 2 commits into from

Conversation

hearsilent
Copy link
Contributor

Improve circle dimen layer in 19+ devices

Screenshots

Pre 19 devices

device-2018-10-01-165110
2018-10-01 4 56 41

19+ devices

device-2018-10-01-163732
2018-10-01 4 56 31

@hearsilent
Copy link
Contributor Author

@shliama Can you review this PR 🙏
Thx!

@dmitriy1morozov
Copy link
Contributor

dmitriy1morozov commented Jan 26, 2022

@hearsilent , I've reviewed your PR and it seems to be promising. However, there is one peculiarity that arose with the introduced code. Currently, the library provides dimmed layer for the outer boundaries of the circle in the edit mode. Once the picture is edited the dimmed layer is removed and the image is saved without dimmed outer layer.
Current_edit
Current_result

However, your PR introduces a different behavior. Once the picture is edited, the dimmed layer remains with the saved image:
PR_edit
PR_result

If you feel that this feature is anticipated, could you please provide additional changes so that such behavior can be adjustable? I mean, to provide some flag that will enable/disable outer circle dimmer after editing. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants