Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as_any and as_any_mut #177

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Conversation

stargazing-dino
Copy link
Contributor

Adds as_any and as_any_mut. Helpful in the case of downcasting the traits into concrete types

@janhohenheim
Copy link
Member

Looks good now! I removed the methods on the dialog runner because they would clutter the API a bit :)

@janhohenheim janhohenheim merged commit 6dd2c60 into YarnSpinnerTool:main Feb 6, 2024
6 checks passed
@stargazing-dino
Copy link
Contributor Author

Looks good now! I removed the methods on the dialog runner because they would clutter the API a bit :)

No worries, i forgot text_provider and variable_storage are already exposed so it's trivial to just call it on them directly

thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants