add get_headers_for_node #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Thinking about this, headers might be better exposed as a hashmap<string, string> or a simple getter. Personally fine with either. I checked the C# version and their |
|
Looks sensible! Could you expose a |
|
done |
|
Thanks! Good work :) |
janhohenheim
approved these changes
Mar 6, 2024
|
I'm just using the main branch 😅. Feel free to do it whenever u think best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiyo,
dialoguedoes not currently provide a way to access headers outside of plain "tags" so I thought this might be helpful. As background, I'm putting stuff specific to the scene (like time of day and location) in the headers and want it to change some runtime things.