feat: enable and disable plugins at will!

bin/resources/app/plugins/docs-tooltips/docs-tooltips.js

@@ -1,32 +1,29 @@
 (() => {
   const Preferences = $gmedit['ui.Preferences'];
-
+  const Project = $gmedit['gml.Project'];
+
   const state = {
-    enabled: true,
     strictLatest: false,
     keys: []
   };
 
+  const ogSetText = aceEditor.tooltipManager.ttip.setText;
+
   GMEdit.register('docs-tooltips', {
     init: () => {
+
       downloadLatestDocs();
 
       if (!Preferences.current.docs_tooltips) Preferences.current.docs_tooltips = {
-        enabled: true,
         strictLatest: false,
         keys: []
       };
 
-      state.enabled = Preferences.current.docs_tooltips.enabled;
       state.strictLatest = Preferences.current.docs_tooltips.strictLatest;
       state.keys = Preferences.current.docs_tooltips.keys;
 
-      const ogSetText = aceEditor.tooltipManager.ttip.setText;
       aceEditor.tooltipManager.ttip.setText = function() {
-        if (!state.enabled
-          || (state.strictLatest && $gmedit['gml.Project'].current.version.name != 'v23')
-          || state.keys == null
-        ) {
+        if ((state.strictLatest && !Project.current.isGMS23) || state.keys == null) {
           ogSetText.apply(this, arguments);
           return;
         }
@@ -52,23 +49,18 @@
         }
       }
     },
-    cleanup: () => {}
-  });
-
-  GMEdit.on('preferencesBuilt', function(e) {
-    var out = e.target.querySelector('.plugin-settings[for="docs-tooltips"]');
+    cleanup: () => {
+      aceEditor.tooltipManager.ttip.setText = ogSetText;
+    },
+    buildPreferences: (out) => {
 
-    Preferences.addCheckbox(out, 'Enabled', state.enabled, () => {
-      state.enabled = !state.enabled;
-      Preferences.current.docs_tooltips.enabled = state.enabled;
-      Preferences.save();
-    });
+      Preferences.addCheckbox(out, 'Disable for non GMS2.3+ projects', state.strictLatest, () => {
+        state.strictLatest = !state.strictLatest;
+        Preferences.current.docs_tooltips.strictLatest = state.strictLatest;
+        Preferences.save();
+      });
 
-    Preferences.addCheckbox(out, 'Disable for non GMS2.3+ projects', state.strictLatest, () => {
-      state.strictLatest = !state.strictLatest;
-      Preferences.current.docs_tooltips.strictLatest = state.strictLatest;
-      Preferences.save();
-    });
+    }
   });
 
   function downloadLatestDocs() {

bin/resources/app/plugins/image-viewer/image-viewer.js

@@ -1,54 +1,65 @@
 (function() {
 	//
-	var Panner = $gmedit["editors.Panner"];
-	var Editor = $gmedit["editors.Editor"];
-	function ImageViewer(file) {
-		Editor.call(this, file);
-		this.element = document.createElement("div");
-		this.element.classList.add("resinfo");
-		this.element.classList.add("sprite");
-		//
-		var panner = null;
-		var pandiv = document.createElement("div");
-		this.element.appendChild(pandiv);
-		//
-		var image = document.createElement("img");
-		image.onload = function(_) {
-			panner.recenter();
-		};
-		pandiv.appendChild(image);
-		this.image = image;
-		//
-		panner = new Panner(pandiv, image);
-		this.panner = panner;
-	}
-	ImageViewer.prototype = GMEdit.extend(Editor.prototype, {
-		load: function(data) {
+	const Panner = $gmedit["editors.Panner"];
+	const Editor = $gmedit["editors.Editor"];
+	const FileKind = $gmedit["file.FileKind"];
+
+	class ImageViewer extends Editor {
+
+		constructor(file) {
+
+			super(file);
+
+			this.element = document.createElement("div");
+			this.element.classList.add("resinfo");
+			this.element.classList.add("sprite");
+			//
+			var panner = null;
+			var pandiv = document.createElement("div");
+			this.element.appendChild(pandiv);
+			//
+			var image = document.createElement("img");
+			image.onload = function(_) {
+				panner.recenter();
+			};
+			pandiv.appendChild(image);
+			this.image = image;
+			//
+			panner = new Panner(pandiv, image);
+			this.panner = panner;
+
+		}
+
+		load(_) {
 			this.image.src = this.file.path;
 		}
-	});
-	//
-	var FileKind = $gmedit["file.FileKind"];
-	function KImage() {
-		FileKind.call(this);
+
 	}
-	KImage.prototype = GMEdit.extend(FileKind.prototype, {
-		init: function(file, data) {
+
+	class KImage extends FileKind {
+
+		static inst = new KImage();
+
+		init(file, _) {
 			file.editor = new ImageViewer(file);
 		}
-	});
-	//
+
+	}
+
 	GMEdit.register("image-viewer", {
 		init: function() {
-			var kimg = new KImage();
-			FileKind.register("png", kimg);
-			FileKind.register("jpg", kimg);
-			FileKind.register("jpeg", kimg);
-			FileKind.register("gif", kimg);
-			FileKind.register("bmp", kimg);
+			FileKind.register("png", KImage.inst);
+			FileKind.register("jpg", KImage.inst);
+			FileKind.register("jpeg", KImage.inst);
+			FileKind.register("gif", KImage.inst);
+			FileKind.register("bmp", KImage.inst);
 		},
 		cleanup: function() {
-			// todo
+			FileKind.deregister("png", KImage.inst);
+			FileKind.deregister("jpg", KImage.inst);
+			FileKind.deregister("jpeg", KImage.inst);
+			FileKind.deregister("gif", KImage.inst);
+			FileKind.deregister("bmp", KImage.inst);
 		}
 	});
 })();

bin/resources/app/plugins/ini-editor/ini-editor.js

@@ -150,13 +150,19 @@
 	KIni.prototype = GMEdit.extend(KCode.prototype, {
 		// we don't need to override anything if it's pure code
 	});
-	//
+
+	var kini = new KIni();
+
 	GMEdit.register("ini-editor", {
-		init: function() {
-			var kini = new KIni();
+		init: () => {
 			FileKind.register("ini", kini);
 			FileKind.register("cfg", kini);
 			FileKind.register("conf", kini);
+		},
+		cleanup: () => {
+			FileKind.deregister("ini", kini);
+			FileKind.deregister("cfg", kini);
+			FileKind.deregister("conf", kini);
 		}
 	});
 })();

bin/resources/app/plugins/outline-view/outline-view.js

@@ -700,55 +700,85 @@
 
 	}
 
-	function init() {
-		AceCommands.add({
-			name: "toggleOutlineView",
-			//bindKey: "Ctrl-Shift-O", // if you'd like
-			exec: function(editor) {
-				toggle();
-				var currPrefs = FileWrap.readConfigSync("config", Preferences.path);
-				if (currPrefs) {
-					var currOV = currPrefs.outlineView;
-					if (currOV == null) currOV = currPrefs.outlineView = {};
-					currOV.hide = !visible;
-					FileWrap.writeConfigSync("config", Preferences.path, currPrefs);
+	function opt(ov, name, def) {
+		if (!ov) return def;
+		var val = ov[name];
+		return val !== undefined ? val : def;
+	}
+
+	function getDisplayMode(currOV) {
+		var dm = opt(currOV, "displayMode", null);
+		if (dm == null) dm = opt(currOV, "currOnly", false) ? 0 : 1;
+		return dm;
+	}
+
+	var toggleOutlineViewCommand;
+	var toggleOutlineViewPaletteCommand;
+
+	var currPrefs = Preferences.current;
+	var currOV = currPrefs.outlineView;
+
+	function prepareOV() {
+		currOV = Preferences.current.outlineView;
+		if (!currOV) currOV = Preferences.current.outlineView = {};
+		return currOV;
+	}
+
+	GMEdit.register("outline-view", {
+		init: () => {
+
+			toggleOutlineViewCommand = {
+				name: "toggleOutlineView",
+				//bindKey: "Ctrl-Shift-O", // if you'd like
+				exec: function(editor) {
+					toggle();
+					var currPrefs = FileWrap.readConfigSync("config", Preferences.path);
+					if (currPrefs) {
+						currOV = currPrefs.outlineView;
+						if (currOV == null) currOV = currPrefs.outlineView = {};
+						currOV.hide = !visible;
+						FileWrap.writeConfigSync("config", Preferences.path, currPrefs);
+					}
 				}
+			};
+
+			toggleOutlineViewPaletteCommand = {
+				name: "Toggle outline view",
+				exec: "toggleOutlineView",
+				title: ""
+			};
+
+			AceCommands.add(toggleOutlineViewCommand);
+			AceCommands.addToPalette(toggleOutlineViewPaletteCommand);
+
+			setDisplayMode(getDisplayMode(currOV))
+			showAtTop = opt(currOV, "showAtTop", true);
+			showFuncArgs = opt(currOV, "showFuncArgs", true);
+
+			GMEdit.on("fileRename", onFileRename);
+
+			if (!(currOV && currOV.hide)) {
+				toggle();
 			}
-		});
-		AceCommands.addToPalette({
-			name: "Toggle outline view",
-			exec: "toggleOutlineView",
-			title: ""
-		});
-		//
-		var currPrefs = Preferences.current;
-		var currOV = currPrefs.outlineView;
-		function opt(ov, name, def) {
-			if (!ov) return def;
-			var val = ov[name];
-			return val !== undefined ? val : def;
-		}
-		function prepareOV() {
-			var currOV = Preferences.current.outlineView;
-			if (!currOV) currOV = Preferences.current.outlineView = {};
-			return currOV;
-		}
-		if (!(currOV && currOV.hide)) toggle();
-		function getDisplayMode(currOV) {
-			var dm = opt(currOV, "displayMode", null);
-			if (dm == null) dm = opt(currOV, "currOnly", false) ? 0 : 1;
-			return dm;
-		}
-		setDisplayMode(getDisplayMode(currOV))
-		showAtTop = opt(currOV, "showAtTop", true);
-		showFuncArgs = opt(currOV, "showFuncArgs", true);
-		//
-		GMEdit.on("preferencesBuilt", function(e) {
-			var out = e.target.querySelector('.plugin-settings[for="outline-view"]');
-			var currOV = Preferences.current.outlineView;
+
+		},
+		cleanup: function() {
+
+			AceCommands.remove(toggleOutlineViewCommand);
+			AceCommands.removeFromPalette(toggleOutlineViewPaletteCommand);
+
+			GMEdit.off("fileRename", onFileRename);
+
+			if (visible) {
+				toggle();
+			}
+
+		},
+		buildPreferences: (out) => {
+			currOV = Preferences.current.outlineView;
 			var hideCtr = Preferences.addCheckbox(out, "Hide", currOV && currOV.hide, function(val) {
 				toggle();
-				var currOV = prepareOV();
+				currOV = prepareOV();
 				currOV.hide = !visible;
 				Preferences.save();
 			});
@@ -761,37 +791,27 @@
 			];
 			Preferences.addDropdown(out, "Display mode", displayModes[getDisplayMode(currOV)], displayModes, function(val) {
 				var i = displayModes.indexOf(val);
-				var currOV = prepareOV();
+				currOV = prepareOV();
 				currOV.displayMode = i;
 				setDisplayMode(i);
 				Preferences.save();
 				toggle_sync();
 				forceRefresh();
 			})
 			Preferences.addCheckbox(out, "Show 2.3 function arguments", opt(currOV, "showFuncArgs", true), function(val) {
-				var currOV = prepareOV();
+				currOV = prepareOV();
 				showFuncArgs = currOV.showFuncArgs = val;
 				currEl = null;
 				Preferences.save();
 				forceRefresh();
 			});
 			Preferences.addCheckbox(out, "Scroll to top upon navigation", opt(currOV, "showAtTop", true), function(val) {
-				var currOV = prepareOV();
+				currOV = prepareOV();
 				showAtTop = currOV.showAtTop = val;
 				currEl = null;
 				Preferences.save();
 				forceRefresh();
 			});
-		});
-
-		GMEdit.on("fileRename", onFileRename);
-
-	}
-
-	GMEdit.register("outline-view", {
-		init: init,
-		cleanup: function() {
-			// todo
 		},
 		_modeMap: modeMap
 	});

src/Main.hx

@@ -132,17 +132,18 @@ class Main {
 		ProjectStyle.init();
 		FileDrag.init();
 		ChromeTabs.init();
+		PluginManager.initApi();
 		Project.init();
 		aceEditor.statusBar.update();
+		Project.nameNode.innerText = "Loading project...";
+		Project.openInitialProject();
 		Project.nameNode.innerText = "Loading plugins...";
-		plugins.PluginManager.init(function() {
-			Project.nameNode.innerText = "Loading project...";
-			Project.openInitialProject();
+		PluginManager.loadInstalledPlugins().then(function(_) {
 			#if lwedit
 			aceEditor.session = WelcomePage.init(aceEditor);
 			LiveWeb.init();
 			#end
-			PluginManager.dispatchInitCallbacks();
+			PluginManager.startPlugins();
 		});
 		Console.log("hello!");
 		StartupTests.main();