Better handle existing user preferences with time slot specified #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing behavior is that we wouldn't subscribe a user to a new time slot if they were already subscribe to one even if it wasn't the one we picked as the best. That behavior doesn't make sense if the time slot information is specified. I updated this, so that if time slot information is specified we will create a user preferences even if they are subscribed to another time slot and made it only update the auto_opt_in information existing user preferences that are for the specified time slot.
ghost
requested a review
from 
ymilki
approved these changes
Oct 21, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior is that we wouldn't subscribe a user to a new time slot if they were already subscribe to one even if it wasn't the one we picked as the best. That behavior doesn't make sense if the time slot information is specified. I updated this, so that if time slot information is specified we will create a user preferences even if they are subscribed to another time slot and made it only update the auto_opt_in information existing user preferences that are for the specified time slot.