Bump AGP 8.0.2, Gradle 8.3, Kotlin 1.8.21, Prod & Test Libs to latest #98
Conversation
abdallaadelessa
force-pushed
the
abdullaessa/bump-versions
branch
5 times, most recently
from
74bad36
to
bf5e578
Compare
| @@ -41,14 +53,21 @@ jobs: | |||
| key: cache-gradle-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }} | |||
| restore-keys: | | |||
| cache-gradle- | |||
| - name: Delete Maven Settings file | |||
| run: rm ~/.m2/settings.xml | |||
There was a problem hiding this comment.
After installing java 17
i faced a problem with the maven publish plugin net.linguica.maven-settings
it seems that we have some servers here ~/.m2/settings.xml but we don’t have ~/.m2/settings-security.xml (with master password) to encrypt the servers passwords
The gradle was crashing here
https://github.com/mark-vieira/gradle-maven-settings-plugin/blob/master/src/main/groovy/net/linguica/gradle/maven/settings/LocalMavenSettingsLoader.java#L89
My workaround is to just delete the ~/.m2/settings.xml before triggering the build 😄
There was a problem hiding this comment.
it might be because of setup-java github action which i am using to install java 17
https://github.com/actions/setup-java/tree/main#maven-options
it seems to generate ~/.m2/settings.xml after installing java 17
There was a problem hiding this comment.
it should be fine for now i think as long as it doesn’t impact development or final publishing
| // Java | ||
| const val SOURCE_COMPATIBILITY = 11 | ||
| const val TARGET_COMPATIBILITY = 11 |
There was a problem hiding this comment.
Can you make sure to declare these updates in the change log: https://github.com/Yelp/bento/blob/master/CHANGELOG.md#-breaking-changes
There was a problem hiding this comment.
i updated the commit message to include ! in order to be marked as a breaking change in the change log
https://www.conventionalcommits.org/en/v1.0.0/
abdallaadelessa
force-pushed
the
abdullaessa/bump-versions
branch
from
bf5e578
to
ea8563a
Compare
Fix a crash in the sample app
Bump Libs
Fix android tests