Skip to content

Commit

Permalink
Add rfc3339-validator to requirements-dev.txt to workaround a mystery…
Browse files Browse the repository at this point in the history
… issue where pip is not in stalling this jsonschema extra by default
  • Loading branch information
jtwang committed Dec 13, 2023
1 parent f242852 commit 46f85c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# TODO: avoids an issue with hanging forever in tests (CORESERV-12009).
# Inclusion of rfc3339-validator here is a workaround for an issue where
# pip is not installing this package (defined by `jsonschema[format-nongpl]`).
# This issue sounds similar to https://github.com/pypa/pip/issues/3903, but
# that was fixed in pip 20.3 and we're still seeing this issue on 22.0.2.
jsonschema<4
mock
mypy
Expand All @@ -7,6 +11,7 @@ pre-commit
pytest
pytest-benchmark[histogram]
pytest-cov
rfc3339-validator
types-mock
types-python-dateutil
types-pytz
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
],
install_requires=[
"jsonref",
"jsonschema[format]>=2.5.1",
"jsonschema[format-nogpl]>=2.5.1",
"python-dateutil",
"pyyaml",
'requests',
Expand Down

0 comments on commit 46f85c1

Please sign in to comment.