Removes path from span name to normalize it #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to ntex 1.1 (breaking changes)
Document Lua crypto module.
- Use bytes-based regex engine - Use `LuaString` instead of `String` where possible - Replace `safe_cell` with `ouroboros` - Use global regex cache instead of local one
Add documentation
- Add `sha1`/`encrypt`/`decrypt` functions - Make `sha256` sync (do not send operation to threadpool (yet))
- Rename `base64_urlsafe_encode` to `base64url_encode` (same for decode) - Add `hex_encode`/`hex_decode` functions
Fix the handler to avoid recursive overflow.
- `EX_COMPRESSED` - `HEADERS_V2`
The method was marked private and wrong method from `IntoLua` trait was used instead.
This would allow to collect metrics and track stored response sizes.
khvzak
force-pushed
the
dev
branch
2 times, most recently
from
5c97142
to
155b45f
Compare
|
Closed in favour of the following change that allows overriding default span name in lua code: 289f9e8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem or Feature
Casper generates very high cardinality for span names. The service does not perform the mapping from path to endpoint within the downstream service, but instead does the routing from namespace to downstream service. This makes it difficult for it to map a path to a low-cardinality span name.
Solution
Remove path from span name. URI is still retrievable from the
request.uriattribute.