The colon equal sign regex should contain both colon and equal. Neith…

…er is optional. Specific for assignment and declaration in golang (#675)
Yelp · Apr 11, 2023 · 44095a0 · 44095a0
1 parent 1bf8134
commit 44095a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/detect_secrets/plugins/keyword.py b/detect_secrets/plugins/keyword.py
@@ -98,7 +98,7 @@
 
 FOLLOWED_BY_COLON_EQUAL_SIGNS_REGEX = re.compile(
     # e.g. my_password := "bar" or my_password := bar
-    r'{denylist}({closing})?{whitespace}:=?{whitespace}({quote}?)({secret})(\3)'.format(
+    r'{denylist}({closing})?{whitespace}:={whitespace}({quote}?)({secret})(\3)'.format(
         denylist=DENYLIST_REGEX,
         closing=CLOSING,
         quote=QUOTE,

diff --git a/tests/plugins/keyword_test.py b/tests/plugins/keyword_test.py
@@ -83,6 +83,8 @@
     ('password := "somefakekey"', None),    # 'fake' in the secret
     ('some_key = "real_secret"', None),     # We cannot make 'key' a Keyword, too noisy)
     ('private_key "hopenobodyfindsthisone\';', None),  # Double-quote does not match single-quote)
+    ('password: real_key', None),
+    ('password: "real_key"', None),
     (LONG_LINE, None),  # Long line test
 ]