Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend keywords #656

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nimrodkor
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
  • What kind of change does this PR introduce?
    Added 2 new keywords to the keyword detector that we found to be rampant:
  1. stuff that ends with _pass
  2. token
  • What is the current behavior?
    secrets are not being flagged

  • What is the new behavior (if this is a feature change)?
    these secrets are being flagged

  • Does this PR introduce a breaking change?
    No

  • Other information:

@nimrodkor
Copy link
Contributor Author

Had to remove python 3.6 as it isn't supported any longer by GHA. Now I see it is failing on finding secrets in my changes :(
Help would be appreciated, I'm sure I didn't add any secret...

@jpdakran
Copy link
Member

Hi. Please merge master to your branch to re-run CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants