fix(telegram_bot_token): Regex must match just bot tokens

[jfagoagas]

• Please check if the PR fulfils these requirements

• Tests for the changes have been added

• Docs have been added / updated

• All CI checks are green

(venv) ➜  time python -m pytest tests/plugins/telegram_token_test.py
================================================================================ test session starts =================================================================================
platform darwin -- Python 3.11.9, pytest-7.4.3, pluggy-1.5.0
rootdir: /private/tmp/detect-secrets
plugins: xdist-3.6.1
collected 6 items

tests/plugins/telegram_token_test.py ......                                                                                                                                    [100%]

================================================================================= 6 passed in 0.05s ==================================================================================
python -m pytest tests/plugins/telegram_token_test.py  0,21s user 0,04s system 96% cpu 0,262 total

• What kind of change does this PR introduce?

This PR fixes a bug with the TelegramBotToken since some AWS ARNs were matched against it due to the regex configured in the deny_list.

• What is the current behaviour?

The following AWS ARN arn:aws:sns:aaa:111122223333:aaaaaaaaaaaaaaaaaaassssssdddddddddddd matches against the TelegramBotToken when the verify option is not enabled, but it should not be needed to be verified since it is not.

This match because the regex is not enough restrictive from the beginning and the end.

• What is the new behaviour (if this is a feature change)?
  Add the start-of-line ^ and end-of-line $ character to reduce false positives.

• Does this PR introduce a breaking change?

No.

• Other information:

[jfagoagas]

Pinning @lorenzodb1 @KevinHock @domanchi to see if this can get a review soon. Thanks in advance!!

[lorenzodb1]

Reading the Telegram docs, I found that

The token looks something like 123456:ABC-DEF1234ghIkl-zyx57W2v1u123ew11

which I assume means there's a specific format in terms of which characters will be upper case and which will be lower case. If that's correct, would you mind making the regex more accurate?

[jfagoagas]

Hello @lorenzodb1 I'm not sure if that's accurate since they also states this in their documentation

The token is a string, like 110201543:AAHdqTcvCH1vGWJxfSeofSAs0K5PALDsaw, which is required to authorize the bot and send requests to the Bot API. Keep your token secure and store it safely, it can be used by anyone to control your bot.

https://core.telegram.org/bots/features#creating-a-new-bot

[jfagoagas]

The regex configured is the same as Trufflehog's https://github.com/trufflesecurity/trufflehog/blob/57802abf5276961426482ace808057016c714958/pkg/detectors/telegrambottoken/telegrambottoken.go#L27

[lorenzodb1]

Thank you for your contribution!

[jfagoagas]

Hello @lorenzodb1 is there any ETA to have this included in a new release? Is something we do really need and we are trying not to vendor/fork the repository.

Thank you!

[jfagoagas]

@lorenzodb1 @KevinHock @domanchi Any updates for a new release? Thanks!

[lorenzodb1]

@jfagoagas we're planning to make a release soon. Either @jpdakran or myself will make one. Thank you for your patience.