PAASTA-17941: fix topology spread constraint option by using snake_ca…

…se instead of camelCase (#3644) Problem ----- Currently, if the Topology Spread Constraints option is set, `setup_kubernetes_job` will fail because the pod spec kwarg `topologySpreadConstraints` is not valid. Solution ----- Use snake_case `topology_spread_constraints` instead. Apparently the translation to valid k8s json manifests happens at a later stage. Signed-off-by: Max Falk <[email protected]>
Yelp · Jul 10, 2023 · 70092c5 · 70092c5
1 parent 09a9e32
commit 70092c5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/paasta_tools/kubernetes_tools.py b/paasta_tools/kubernetes_tools.py
@@ -1978,9 +1978,9 @@ def get_pod_template_spec(
             topology_spread_constraints=system_paasta_config.get_topology_spread_constraints(),
         )
         if pod_topology_spread_constraints:
-            constraints = pod_spec_kwargs.get("topologySpreadConstraints", [])
+            constraints = pod_spec_kwargs.get("topology_spread_constraints", [])
             constraints += pod_topology_spread_constraints
-            pod_spec_kwargs["topologySpreadConstraints"] = constraints
+            pod_spec_kwargs["topology_spread_constraints"] = constraints
 
         termination_grace_period = self.get_termination_grace_period()
         if termination_grace_period is not None: