removing unused client

Yelp · Jul 14, 2023 · 86a66da · 86a66da
1 parent 9171a41
commit 86a66da
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/paasta_tools/kubernetes_tools.py b/paasta_tools/kubernetes_tools.py
@@ -3859,14 +3859,13 @@ def mode_to_int(mode: Optional[Union[str, int]]) -> Optional[int]:
 
 
 def update_crds(
-    kube_client: KubeClient,
+    apiextensions: Union[
+        kube_client.ApiextensionsV1Api, kube_client.ApiextensionsV1beta1Api
+    ],
     desired_crds: Collection[
         Union[V1CustomResourceDefinition, V1beta1CustomResourceDefinition]
     ],
     existing_crds: V1CustomResourceDefinitionList,
-    apiextensions: Union[
-        kube_client.ApiextensionsV1Api, kube_client.ApiextensionsV1beta1Api
-    ],
 ) -> bool:
     success = True
     for desired_crd in desired_crds:

diff --git a/paasta_tools/setup_kubernetes_crd.py b/paasta_tools/setup_kubernetes_crd.py
@@ -132,10 +132,9 @@ def setup_kube_crd(
             desired_crds.append(desired_crd)
 
         if update_crds(
-            kube_client=kube_client,
+            apiextensions=apiextension,
             desired_crds=desired_crds,
             existing_crds=existing_crds,
-            apiextensions=apiextension,
         ):
             return True
     return False