Skip to content

Commit

Permalink
PAASTA-17941: fix topology spread constraint option by using snake_ca…
Browse files Browse the repository at this point in the history
…se instead of camelCase

Signed-off-by: Max Falk <[email protected]>
  • Loading branch information
gmdfalk committed Jul 10, 2023
1 parent 09a9e32 commit 9db3994
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions paasta_tools/kubernetes_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -1978,9 +1978,9 @@ def get_pod_template_spec(
topology_spread_constraints=system_paasta_config.get_topology_spread_constraints(),
)
if pod_topology_spread_constraints:
constraints = pod_spec_kwargs.get("topologySpreadConstraints", [])
constraints = pod_spec_kwargs.get("topology_spread_constraints", [])
constraints += pod_topology_spread_constraints
pod_spec_kwargs["topologySpreadConstraints"] = constraints
pod_spec_kwargs["topology_spread_constraints"] = constraints

termination_grace_period = self.get_termination_grace_period()
if termination_grace_period is not None:
Expand Down Expand Up @@ -2081,6 +2081,9 @@ def get_pod_template_spec(
labels["paasta.yelp.com/deploy_group"] = self.get_deploy_group()
labels["paasta.yelp.com/scrape_piscina_prometheus"] = "true"

if self.get_service() == "compute-infra-test-service":
print(pod_spec_kwargs)

return V1PodTemplateSpec(
metadata=V1ObjectMeta(
labels=labels,
Expand Down

0 comments on commit 9db3994

Please sign in to comment.