Upgrading kubernetes client library to v24.2.0 #3632
Conversation
tests/test_kubernetes_tools.py
Outdated
| @@ -3905,7 +3905,7 @@ def test_warning_big_bounce(): | |||
| job_config.format_kubernetes_app().spec.template.metadata.labels[ | |||
| "paasta.yelp.com/config_sha" | |||
| ] | |||
| == "config9e0d925d" | |||
| == "configc22655c7" | |||
There was a problem hiding this comment.
huh, interesting - I wonder what changed here in the underlying config (maybe the ordering in
Line 3699 in b75e2d5
wilmer05
force-pushed
the
u/wilmerrafael/PAASTA-17925_upgrading_kubernetes_library
branch
from
b75e2d5
to
0fc36f8
Compare
| @@ -33,7 +33,7 @@ | |||
|
|
|||
|
|
|||
| INTERNAL_CRDS = [ | |||
| V1beta1CustomResourceDefinition( | |||
| V1CustomResourceDefinition( | |||
There was a problem hiding this comment.
we need to update this CRD definition as well. there are few deprecated keys in V1
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122
i have an open PR which was sortof doing the same thing.
https://github.com/Yelp/paasta/pull/3611/files#diff-59d82c9819b7780a1257b5ef686a4f93d5b6626181b33637448ce656f3ce6650
There was a problem hiding this comment.
thanks for the catch, I will add the same in this PR
There was a problem hiding this comment.
there is another CRD definition L85:L116 that we might need to update.
sorry, I didn't see that earlier
There was a problem hiding this comment.
updated it, thanks for the catch
Need to do a clean release of PaaSTA v0.183.0 that we can release to production. This PR is currently blocking that release because PaaSTA cannot apply CRDs with version `v1beta1`. We'll re-apply this PR once 183 is released. Reverts #3632
As part of our kubernetes upgrade (to 1.22) we need to upgrade kubernetes libraries being used to support k8s 1.22.
The kubernetes client library got updated in this PR to v24.2.0 and the proper tests were updated
PAASTA-17925