Add support for eks cluster not matching --cluster spark arg #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may make a different cluster for spark in dev, but we don't really want to deal with a soaconfigs migration in case we decide to rollback This PR transparently sets the right eks cluster params based on whether or not eks usage is toggled on or off
nemacysts
requested review from
CaptainSame,
jfongatyelp,
88manpreet,
bobokun,
EmanElsaban and
KaspariK
bobokun
approved these changes
Jun 30, 2023
jfongatyelp
approved these changes
Jul 3, 2023
Co-authored-by: Jen Patague <[email protected]>
88manpreet
approved these changes
Jul 27, 2023
bobokun
approved these changes
Jul 27, 2023
EmanElsaban
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may make a different cluster for spark in dev, but we don't really want to deal with a soaconfigs migration in case we decide to rollback
This PR transparently sets the right eks cluster params based on whether or not eks usage is toggled on or off